fix: bound scrape query parameters - #2334
Merged
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
|
zeitlinger
marked this pull request as ready for review
July 23, 2026 11:18
jaydeluca
approved these changes
Aug 10, 2026
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This was referenced Aug 18, 2026
zeitlinger
added a commit
that referenced
this pull request
Aug 19, 2026
## Summary - document the default implementation values `maxQueryStringLength = 64 * 1024` and `maxQueryParameterCount = 1024` in `PrometheusHttpRequest` JavaDoc - clarify that these values are fixed implementation limits, not runtime configuration - clarify that invalid or excessive query parameters produce HTTP 400 Follow-up to [#2334](#2334) and [discussion_r3752169308](#2334 (comment)). ## Validation - `mise run lint:fix` *(blocked by the pre-existing 403 response for the README CNCF Slack link; the push hook passed using a temporary local-only README substitution, restored before completion)* - `mise run build` - `./mvnw -pl prometheus-metrics-exporter-common test -Dcoverage.skip=true` --------- Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the focused replacement for the #2285 portion of #2297.
Fixes #2285
Ongoing discussion
None currently. The malformed percent-encoding case raised during the earlier review is covered and returns HTTP 400.
Validation
mise run lint:fixmise run build./mvnw test -pl prometheus-metrics-exporter-common,prometheus-metrics-model -Dcoverage.skip=true -Dcheckstyle.skip=true