fix: keep custom exemplar labels caller-controlled - #2194
Merged
jaydeluca merged 1 commit intoJun 5, 2026
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
zeitlinger
marked this pull request as ready for review
June 5, 2026 13:45
jaydeluca
pushed a commit
that referenced
this pull request
Jun 5, 2026
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
PR #2191 reused
doSampleExemplar()from the custom exemplar path. After that method started merging per-metric and global label suppliers,incWithExemplar(...)andobserveWithExemplar(...)also picked up supplier labels, even though the new API/docs describe that behavior for automatically-sampled exemplars only.Impact
Custom exemplars remain explicitly controlled by the caller, while automatically-sampled exemplars still receive the configured extra labels.
Validation
mise run build./mvnw -q -pl prometheus-metrics-core -am -Dtest=CounterTest -Dsurefire.failIfNoSpecifiedTests=false test -Dcoverage.skip=true -Dcheckstyle.skip=truemise run lint:fix