feat: Add OpenMetrics2 enabled flag - #1953
Merged
Merged
Conversation
The OM2 writer selection previously activated when any feature flag was set, but there was no way to just enable OM2 without opting into a specific feature. This adds an explicit `enabled` gate (io.prometheus.openmetrics2.enabled) as the single control for OM2 writer selection. Feature flags alone no longer activate OM2. The programmatic `enableOpenMetrics2()` configurator sets enabled=true implicitly, matching its name. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
zeitlinger
marked this pull request as ready for review
March 17, 2026 07:51
This was referenced Mar 17, 2026
jaydeluca
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
io.prometheus.openmetrics2.enabledas the explicit gate for OM2writer selection. Feature flags alone no longer activate OM2.
enableOpenMetrics2()programmatic configurator setsenabled=trueimplicitly.
name-preservation behavior without committing to other OM2 features.
Test plan
OpenMetrics2PropertiesTestcoversenabledin load, builder,enableAll, defaultValues
ExpositionFormatsTestverifies OM2 activation requiresenabled=true, feature flags alone fall back to OM1BEGIN_COMMIT_OVERRIDE
chore: Add OpenMetrics2 enabled flag
END_COMMIT_OVERRIDE