Skip to content

fix: exclude standalone examples from mise run format - #1931

Merged
zeitlinger merged 3 commits into
mainfrom
fix-mise-format
Mar 4, 2026
Merged

fix: exclude standalone examples from mise run format#1931
zeitlinger merged 3 commits into
mainfrom
fix-mise-format

Conversation

@zeitlinger

@zeitlinger zeitlinger commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • mise run format (i.e. spotless:apply) fails on JDK 25+ because
    standalone example POMs don't inherit the spotless plugin from the
    project parent, but are pulled into the reactor via the
    examples-and-integration-tests profile
  • Fix: use the fully-qualified plugin goal with profile deactivation
  • Add lint:example-poms check to catch this class of issue

Relates #1927 (comment)

Test plan

  • mise run format succeeds
  • lint:example-poms passes with the fix
  • lint:example-poms fails when reverting the fix
@zeitlinger
fix: exclude standalone examples from mise run format
ab9480c 
Standalone example POMs don't inherit the spotless plugin from the
project parent, so `spotless:apply` fails when they're in the reactor
(JDK 25+ activates the examples-and-integration-tests profile).

Use the fully-qualified plugin goal with profile deactivation to
skip these modules. Add a `lint:example-poms` check to catch this
class of issue in the future.

Fixes #1927
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger mentioned this pull request Mar 3, 2026
Merged
@zeitlinger
fix: make lint script executable, update AGENTS.md
7ce2631 
- chmod +x example-poms.py so mise discovers it as a task
- Remove stale `./mvnw spotless:apply` comment from AGENTS.md
- Add "run lint before pushing" rule to AGENTS.md
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger
style: fix Black formatting in example-poms.py
bcb6b7d 
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
jaydeluca
jaydeluca approved these changes Mar 3, 2026
View reviewed changes

@jaydeluca jaydeluca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for jumping on this!
Comment thread AGENTS.md
**ALWAYS** run `mise run lint` before pushing to verify
all lints pass. CI runs the same checks and will fail
if any lint is violated.

@jaydeluca jaydeluca Mar 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@zeitlinger
zeitlinger merged commit 537fb88 into main Mar 4, 2026
9 checks passed
@zeitlinger
zeitlinger deleted the fix-mise-format branch March 4, 2026 06:40
This was referenced Mar 19, 2026
Merged
Merged
zeitlinger added a commit that referenced this pull request Mar 19, 2026
@github-actions @zeitlinger
chore: release main (#1965)
3524bcf 
🤖 I have created a release *beep* *boop*
---


<details><summary>1.5.1</summary>

##
[1.5.1](v1.5.0...v1.5.1)
(2026-03-19)


### Bug Fixes

* **deps:** update dependency io.prometheus:prometheus-metrics-bom to
v1.5.0 ([#1877](#1877))
([043fc57](043fc57))
* **deps:** update dependency
org.springframework.boot:spring-boot-starter-parent to v4.0.3
([#1900](#1900))
([0d800d0](0d800d0))
* **deps:** update jetty monorepo to v12.1.7
([#1932](#1932))
([5bd3b79](5bd3b79))
* **deps:** update junit-framework monorepo to v6.0.3
([#1880](#1880))
([05ad751](05ad751))
* exclude standalone examples from `mise run format`
([#1931](#1931))
([537fb88](537fb88))
* Handle empty datapoints in otel exporter
([#1898](#1898))
([59c8552](59c8552))
* inline set-version logic in build-release.sh
([#1884](#1884))
([c050435](c050435))
* reduce lychee retries to avoid compounding GitHub 429s
([#1940](#1940))
([cc17d6e](cc17d6e))
* remove version manipulation from build-release.sh
([#1886](#1886))
([93e2b6d](93e2b6d))
* trigger Maven deploy on release-please published events
([#1966](#1966))
([643d0e7](643d0e7))
* use /tree/ instead of /blob/ for directory URL
([#1944](#1944))
([b81332e](b81332e))
* use maven release type for release-please
([#1967](#1967))
([ff3bd2d](ff3bd2d))


### Documentation

* document DCO sign-off requirement for contributions
([#1937](#1937))
([0860e77](0860e77))
</details>

---
> [!IMPORTANT]
> Close and reopen this PR to trigger CI checks.

---------

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This was referenced Mar 19, 2026
Closed
Closed
Merged
zeitlinger pushed a commit that referenced this pull request Mar 20, 2026
@github-actions
chore(main): release 1.5.1 (#1979)
b27d2d4 
🤖 I have created a release *beep* *boop*
---


##
[1.5.1](v1.5.0...v1.5.1)
(2026-03-20)


### Bug Fixes

* **deps:** update dependency io.prometheus:prometheus-metrics-bom to
v1.5.0 ([#1877](#1877))
([043fc57](043fc57))
* **deps:** update dependency
org.springframework.boot:spring-boot-starter-parent to v4.0.3
([#1900](#1900))
([0d800d0](0d800d0))
* **deps:** update jetty monorepo to v12.1.7
([#1932](#1932))
([5bd3b79](5bd3b79))
* **deps:** update junit-framework monorepo to v6.0.3
([#1880](#1880))
([05ad751](05ad751))
* exclude standalone examples from `mise run format`
([#1931](#1931))
([537fb88](537fb88))
* fix release-please PR title pattern and permissions
([#1978](#1978))
([d737978](d737978))
* Handle empty datapoints in otel exporter
([#1898](#1898))
([59c8552](59c8552))
* inline set-version logic in build-release.sh
([#1884](#1884))
([c050435](c050435))
* reduce lychee retries to avoid compounding GitHub 429s
([#1940](#1940))
([cc17d6e](cc17d6e))
* remove version manipulation from build-release.sh
([#1886](#1886))
([93e2b6d](93e2b6d))
* trigger Maven deploy on release-please published events
([#1966](#1966))
([643d0e7](643d0e7))
* use /tree/ instead of /blob/ for directory URL
([#1944](#1944))
([b81332e](b81332e))
* use maven release type for release-please
([#1967](#1967))
([ff3bd2d](ff3bd2d))


### Documentation

* document DCO sign-off requirement for contributions
([#1937](#1937))
([0860e77](0860e77))

---
> [!IMPORTANT]
> Close and reopen this PR to trigger CI checks.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@zeitlinger @jaydeluca