Skip to content

feat: Add readTimeout and conenctionTimeout as configurable parameters - #1658

Merged
zeitlinger merged 3 commits into
prometheus:mainfrom
hmhuan:main
Nov 7, 2025
Merged

feat: Add readTimeout and conenctionTimeout as configurable parameters#1658
zeitlinger merged 3 commits into
prometheus:mainfrom
hmhuan:main

Conversation

@hmhuan

@hmhuan hmhuan commented Nov 1, 2025

Copy link
Copy Markdown
Contributor

I got the issue like below so I would like to contribute to fix it by apply configurable for connectionTimeout and readTimeout.

stack_trace: java.io.IOException: ailed to push metrics to the Prometheus Pushgateway on <pushgateway_address>: Read timed out
Caused by: java.net.SocketTimeoutException: Read timed out
  • AS-IS: the current connectionTimeout and readTimeout is 10s
  • TOBE: we can create builder with connectionTimeout and readTimeout custom value, default value is 10s

@zeitlinger zeitlinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

<version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeitlinger

Copy link
Copy Markdown
Member

A pushed a change that reads the properties from a file to be in line with the other properties

@zeitlinger

Copy link
Copy Markdown
Member

@hmhuan please fix the build - and let me know if you want to have this PR included in the upcoming release

@hmhuan

hmhuan commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

Hi @zeitlinger , Thank you for your support. I will fix the build and update on this weekend.

@hmhuan

hmhuan commented Nov 6, 2025

Copy link
Copy Markdown
Contributor Author

let me know if you want to have this PR included in the upcoming release

Hey @zeitlinger, I have just remove the test dependency and remove redundant test. Please help me to review and include this PR in the upcoming release. Thank you very much

Comment thread .github/workflows/acceptance-tests.yml
hmhuan and others added 3 commits November 7, 2025 07:26
Signed-off-by: huan.huynh <1612858@student.hcmus.edu.vn>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: huan.huynh <1612858@student.hcmus.edu.vn>
Signed-off-by: huan.huynh <1612858@student.hcmus.edu.vn>
@zeitlinger
zeitlinger enabled auto-merge (squash) November 7, 2025 14:33
@zeitlinger
zeitlinger merged commit e7aa3c6 into prometheus:main Nov 7, 2025
7 checks passed
This was referenced Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants