Skip to content

fix: use maven release type for release-please - #1967

Merged
zeitlinger merged 4 commits into
mainfrom
fix/revert-release-and-fix-config
Mar 19, 2026
Merged

fix: use maven release type for release-please#1967
zeitlinger merged 4 commits into
mainfrom
fix/revert-release-and-fix-config

Conversation

@zeitlinger

@zeitlinger zeitlinger commented Mar 19, 2026

Copy link
Copy Markdown
Member

Summary

  • Revert the v1.6.0 release commit (manifest + CHANGELOG) since the
    deploy failed — pom.xml files still had -SNAPSHOT versions
  • Change release-type from java to maven in the release-please
    config so it auto-discovers and updates all pom.xml versions in the
    release commit
  • Remove prometheus-metrics-parent/pom.xml from extra-files since
    the maven strategy handles it automatically

The java release type only updates CHANGELOG and the manifest. The
maven type does XML-aware pom.xml version updates, which is what we
need.

The v1.6.0 tag and GitHub release have already been deleted.

Test plan

  • CI passes
  • After merge, release-please creates a new release PR that includes
    pom.xml version updates
  • Deploy to Maven Central succeeds
@zeitlinger
zeitlinger marked this pull request as ready for review March 19, 2026 14:09
@zeitlinger
Revert "chore: release main (#1962)"
2adf131 
This reverts commit c77112b.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger
fix: use maven release type so release-please updates pom.xml versions
7a3c0ea 
The previous `java` release type only updates CHANGELOG.md and the
manifest, leaving pom.xml files with -SNAPSHOT versions at the tagged
commit. This caused the v1.6.0 deploy to fail with a 405 when Maven
tried to upload snapshots to Central.

The `maven` release type auto-discovers all pom.xml files and updates
their versions in the release commit, making the build-release script's
version manipulation unnecessary.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger
chore: revert pom.xml versions to 1.5.0-SNAPSHOT
63e384d 
The 1.6.0-SNAPSHOT bump was done manually before release-please was
configured with the maven release type. Now that release-please will
handle pom.xml version updates, reset to 1.5.0-SNAPSHOT so the next
release PR sets them to 1.6.0 correctly.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger
fix: format release-please-config.json with Prettier
2392204 
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger
zeitlinger force-pushed the fix/revert-release-and-fix-config branch from ac7d597 to 2392204 Compare March 19, 2026 15:39
@zeitlinger

zeitlinger commented Mar 19, 2026

Copy link
Copy Markdown
Member Author

@jaydeluca can you take a look?
@zeitlinger
zeitlinger merged commit ff3bd2d into main Mar 19, 2026
13 checks passed
@zeitlinger
zeitlinger deleted the fix/revert-release-and-fix-config branch March 19, 2026 17:07
@github-actions github-actions Bot mentioned this pull request Mar 19, 2026
Merged
zeitlinger added a commit that referenced this pull request Mar 19, 2026
@github-actions @zeitlinger
chore: release main (#1965)
3524bcf 
🤖 I have created a release *beep* *boop*
---


<details><summary>1.5.1</summary>

##
[1.5.1](v1.5.0...v1.5.1)
(2026-03-19)


### Bug Fixes

* **deps:** update dependency io.prometheus:prometheus-metrics-bom to
v1.5.0 ([#1877](#1877))
([043fc57](043fc57))
* **deps:** update dependency
org.springframework.boot:spring-boot-starter-parent to v4.0.3
([#1900](#1900))
([0d800d0](0d800d0))
* **deps:** update jetty monorepo to v12.1.7
([#1932](#1932))
([5bd3b79](5bd3b79))
* **deps:** update junit-framework monorepo to v6.0.3
([#1880](#1880))
([05ad751](05ad751))
* exclude standalone examples from `mise run format`
([#1931](#1931))
([537fb88](537fb88))
* Handle empty datapoints in otel exporter
([#1898](#1898))
([59c8552](59c8552))
* inline set-version logic in build-release.sh
([#1884](#1884))
([c050435](c050435))
* reduce lychee retries to avoid compounding GitHub 429s
([#1940](#1940))
([cc17d6e](cc17d6e))
* remove version manipulation from build-release.sh
([#1886](#1886))
([93e2b6d](93e2b6d))
* trigger Maven deploy on release-please published events
([#1966](#1966))
([643d0e7](643d0e7))
* use /tree/ instead of /blob/ for directory URL
([#1944](#1944))
([b81332e](b81332e))
* use maven release type for release-please
([#1967](#1967))
([ff3bd2d](ff3bd2d))


### Documentation

* document DCO sign-off requirement for contributions
([#1937](#1937))
([0860e77](0860e77))
</details>

---
> [!IMPORTANT]
> Close and reopen this PR to trigger CI checks.

---------

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This was referenced Mar 19, 2026
Closed
Closed
Merged
zeitlinger pushed a commit that referenced this pull request Mar 20, 2026
@github-actions
chore(main): release 1.5.1 (#1979)
b27d2d4 
🤖 I have created a release *beep* *boop*
---


##
[1.5.1](v1.5.0...v1.5.1)
(2026-03-20)


### Bug Fixes

* **deps:** update dependency io.prometheus:prometheus-metrics-bom to
v1.5.0 ([#1877](#1877))
([043fc57](043fc57))
* **deps:** update dependency
org.springframework.boot:spring-boot-starter-parent to v4.0.3
([#1900](#1900))
([0d800d0](0d800d0))
* **deps:** update jetty monorepo to v12.1.7
([#1932](#1932))
([5bd3b79](5bd3b79))
* **deps:** update junit-framework monorepo to v6.0.3
([#1880](#1880))
([05ad751](05ad751))
* exclude standalone examples from `mise run format`
([#1931](#1931))
([537fb88](537fb88))
* fix release-please PR title pattern and permissions
([#1978](#1978))
([d737978](d737978))
* Handle empty datapoints in otel exporter
([#1898](#1898))
([59c8552](59c8552))
* inline set-version logic in build-release.sh
([#1884](#1884))
([c050435](c050435))
* reduce lychee retries to avoid compounding GitHub 429s
([#1940](#1940))
([cc17d6e](cc17d6e))
* remove version manipulation from build-release.sh
([#1886](#1886))
([93e2b6d](93e2b6d))
* trigger Maven deploy on release-please published events
([#1966](#1966))
([643d0e7](643d0e7))
* use /tree/ instead of /blob/ for directory URL
([#1944](#1944))
([b81332e](b81332e))
* use maven release type for release-please
([#1967](#1967))
([ff3bd2d](ff3bd2d))


### Documentation

* document DCO sign-off requirement for contributions
([#1937](#1937))
([0860e77](0860e77))

---
> [!IMPORTANT]
> Close and reopen this PR to trigger CI checks.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@zeitlinger @jaydeluca