Skip to content

CI: Build apache module on Unix - #23405

Draft
NattyNarwhal wants to merge 2 commits into
php:masterfrom
NattyNarwhal:apache-module-ci
Draft

CI: Build apache module on Unix#23405
NattyNarwhal wants to merge 2 commits into
php:masterfrom
NattyNarwhal:apache-module-ci

Conversation

@NattyNarwhal

@NattyNarwhal NattyNarwhal commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

There are no unit tests, but a smoke test is an improvement.

Note that the configure script needs httpd-the-executable to run, so not just apache2-dev is sufficient on Debian and Alpine.

Windows according to Shivam builds it with --enable-snapshot-build.

Tested locally on Alpine.

Partially addresses GH-23404
@NattyNarwhal

NattyNarwhal commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

Also will need to be rebased onto 8.4.
@NattyNarwhal

NattyNarwhal commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

I think Clang in macOS/FreeBSD/Alpine is being a bit picky about a convention Apache uses. -Wno-missing-field-initializers?
@ndossche

ndossche commented Aug 21, 2026

Copy link
Copy Markdown
Member

I think Clang in macOS/FreeBSD/Alpine is being a bit picky about a convention Apache uses. -Wno-missing-field-initializers?

Eek, that's not a nice flag to add.
Example from https://httpd.apache.org/docs/current/developer/modguide.html shows to use {} instead of {NULL}, maybe try that instead
@NattyNarwhal

NattyNarwhal commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

For Windows, I think since it does grab apache via the series stuff in php-windows-builder, it might be a matter of just adding apache2handler to the configure flags?
@shivammathur

shivammathur commented Aug 22, 2026

Copy link
Copy Markdown
Member

@NattyNarwhal

For Windows, I think since it does grab apache via the series stuff in php-windows-builder, it might be a matter of just adding apache2handler to the configure flags?

Since we pass --enable-snapshot-build in Windows CI, it already builds apache2handler. That changes all no defaults to yes, (except a few exclusions).
@NattyNarwhal
CI: Build apache module on Unix
2f33db7 
There are no unit tests, but a smoke test is an improvement.

Note that the configure script needs httpd-the-executable to script, so
not just apache2-dev is sufficiaent on Debian and Alpine.

Windows according to Shivam builds it with --enable-snapshot-build.

Tested locally on Alpine.

Partially addresses phpGH-23404
@NattyNarwhal
sapi/apache2handler: Don't use {NULL} for command_rec
f8a1294 
Clang will be mad with -Wmissing-field-initializers, even though Apache
itself does this. Per Nora, [use {} as documented by Apache][modguide].

[modguide]: https://httpd.apache.org/docs/current/developer/modguide.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment