Zend: applied fixers to improve test robustness (1/8) - #23308
Merged
Conversation
NickSdot
force-pushed
the
test/hardening/zend-1
branch
from
August 16, 2026 10:37
80be938 to
c24d54d
Compare
NickSdot
force-pushed
the
test/hardening/zend-1
branch
from
August 16, 2026 12:00
c24d54d to
1a0544e
Compare
jorgsowa
approved these changes
Aug 16, 2026
| @@ -31,7 +31,7 @@ $ref = new \ReflectionFunction(#[A1] function () { }); | |||
| try { | |||
| $ref->getAttributes()[0]->newInstance(); | |||
| } catch (\ArgumentCountError $e) { | |||
| var_dump('ERROR 1', $e->getMessage()); | |||
| echo 'ERROR 1: ', $e::class, ': ', $e->getMessage(), "\n"; | |||
Contributor
There was a problem hiding this comment.
Suggested change
| echo 'ERROR 1: ', $e::class, ': ', $e->getMessage(), "\n"; | |
| echo $e::class, ': ', $e->getMessage(), "\n"; |
I don't think it's necessary. In this whole file.
Contributor
Author
There was a problem hiding this comment.
I agree with you and personally would prefer to remove such things everywhere. Unfortunately others were against removing descriptive pre-/suffixes; without consensus I cannot address it. Maybe we can make this a follow up when 8.6 is out and we have time to discuss it...
| @@ -57,15 +57,15 @@ $ref = new \ReflectionFunction(function () { }); | |||
| try { | |||
| $ref->getAttributes(A1::class, 3); | |||
| } catch (\Error $e) { | |||
| var_dump('ERROR 1', $e->getMessage()); | |||
| echo 'ERROR 1: ', $e::class, ': ', $e->getMessage(), "\n"; | |||
Contributor
There was a problem hiding this comment.
Suggested change
| echo 'ERROR 1: ', $e::class, ': ', $e->getMessage(), "\n"; | |
| echo $e::class, ': ', $e->getMessage(), "\n"; |
The same in this file
NickSdot
force-pushed
the
test/hardening/zend-1
branch
from
August 19, 2026 14:08
1a0544e to
b71541f
Compare
NickSdot
force-pushed
the
test/hardening/zend-1
branch
from
August 21, 2026 18:25
b71541f to
4b527e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asserts error class; extracted from: #22799.
Files with style-only changed were manually reverted.
Split in eight PRs to make reviews easier to digest.