ext/curl: applied fixers to improve test robustness - #23038
Merged
Conversation
Contributor
Author
|
@LamentXU123 since you answered in the other PR with the same maintainer, they seem inactive (last commit last year)? Would you maybe want to look at this one? I can rebase. |
Member
|
I am not responsible for the curl extension. Hmmm, maybe @Sjord can decide this? I am fine with this change btw. |
Contributor
Author
I literally checked CODEOWNERS before I commented this and only saw the one maintainer. Didn't mean to bypass anyone, sorry! |
NickSdot
force-pushed
the
test/hardening/ext-curl
branch
from
August 11, 2026 20:08
470ba1f to
b14eab8
Compare
Contributor
|
Looks good to me. As I said, #23183 also contains some of these changes. |
Contributor
Author
|
The failure is an unrelated flake, ref: #23217 |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asserts error class; extracted from: #22799