ext/json: applied fixers to improve test robustness - #23029
Merged
Conversation
NickSdot
force-pushed
the
test/hardening/ext-json
branch
from
August 4, 2026 14:03
25372da to
5fe4302
Compare
NickSdot
marked this pull request as ready for review
August 4, 2026 15:12
NickSdot
commented
Aug 16, 2026
| @@ -11,4 +11,3 @@ echo "Done\n"; | |||
| --EXPECT-- | |||
| string(7) "[1,2,3]" | |||
| Done | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
This (and following) removes useless second empty line.
NickSdot
force-pushed
the
test/hardening/ext-json
branch
3 times, most recently
from
August 19, 2026 14:08
f4635b4 to
684f514
Compare
NickSdot
force-pushed
the
test/hardening/ext-json
branch
from
August 21, 2026 18:25
684f514 to
ebb32fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asserts error class; extracted from: #22799