Use 'params=None' approach - #42
Open
Flowdalic wants to merge 2 commits into
Open
Conversation
This reverts commit 9b00e4b.
Owner
|
Do you have any code that uses this that I can look at? |
Contributor
Author
|
@petertodd I've extended the commit with a unit test that uses the |
in to_bytes() and stream_deaerialize()
Owner
|
Hey, sorry I haven't merged this yet, travelling. :( Mind writing up a thing in the README explaining the idea behind params, like as a code best practices? I wanted to do that before I merge, but stupid busy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #38 I suggest the following approach.