Skip to content

Add crypto params - #40

Merged
pcothenet merged 1 commit into
mainfrom
pc/btc
Sep 10, 2021
Merged

Add crypto params#40
pcothenet merged 1 commit into
mainfrom
pc/btc

Conversation

@pcothenet

@pcothenet pcothenet commented Sep 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

What

  • Allow crypto estimates via daily balance held

Why

  • More flexible estimates

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?
pcothenet
pcothenet commented Sep 10, 2021
View reviewed changes
Comment thread patch_api/api/estimates_api.py
"year",
"transaction_value_btc_sats",
"timestamp",
"transaction_value_eth_gwei",

@pcothenet pcothenet Sep 10, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we (I) had forgotten a couple parameters. This is why I'm trying to refactor the python SDK generation :)
boconnell2
boconnell2 approved these changes Sep 10, 2021
View reviewed changes

@boconnell2 boconnell2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)
@pcothenet
pcothenet merged commit f02c5e2 into main Sep 10, 2021
@pcothenet
pcothenet deleted the pc/btc branch September 10, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@pcothenet @boconnell2