Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

run tests again that were failing because of #1502 - #1798

Merged
individual-it merged 1 commit into
masterfrom
unskipFailingTests1502
Oct 4, 2019
Merged

run tests again that were failing because of #1502#1798
individual-it merged 1 commit into
masterfrom
unskipFailingTests1502

Conversation

@individual-it

Copy link
Copy Markdown
Member

Description

These tests were failing because of #1502
That issue was fixed in owncloud/core#35879
so let's run them again

Related Issue

part of #1502

Motivation and Context

tests don't like to be ignored https://blog.developer.atlassian.com/open-letter-from-an-ignored-test/

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...
@ownclouders

Copy link
Copy Markdown
Contributor
💥 Acceptance tests webUITrashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/4719/

20190814-104950-894.png
20190814-104951-159.png
20190814-105101-762.png
20190814-105127-041.png

@dpakach dpakach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@individual-it
individual-it requested a review from skshetry October 4, 2019 07:11
@individual-it
individual-it merged commit 0451386 into master Oct 4, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the unskipFailingTests1502 branch October 4, 2019 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA:team Status:Needs-Review Needs review from a maintainer

6 participants