Skip to content
This repository was archived by the owner on Aug 19, 2026. It is now read-only.

Add occ files:remove-storage command - #978

Merged
mmattel merged 8 commits into
masterfrom
new_occ_command
May 31, 2023
Merged

Add occ files:remove-storage command#978
mmattel merged 8 commits into
masterfrom
new_occ_command

Conversation

@mmattel

@mmattel mmattel commented May 10, 2023

Copy link
Copy Markdown
Contributor

Referencing: owncloud/core#40779 (Add command to remove obsolete storages from the filecache)

Adding the occ command referenced by the core PR.

Merge only when the referenced core PR got merged.

NO backport, master only

@jvillafanez pls check if correct, all descriptions are here in the admin docs as it is no config command.

@jvillafanez

Copy link
Copy Markdown
Member

We might need to add some usage examples to clarify the expectations.

Assuming you don't know what storages you could remove, you should use occ files:remove-storage --show-candidates first to get a list of possible obsolete storages. From there, you can use occ files:remove-storage <numeric_id> to remove that storage.

@mmattel

mmattel commented May 10, 2023

Copy link
Copy Markdown
Contributor Author

We might need to add some usage examples to clarify the expectations

Will do.

@mmattel

mmattel commented May 15, 2023

Copy link
Copy Markdown
Contributor Author

I added an example, but it is likely that the table header names will change. Waiting for the core PR.

@phil-davis
phil-davis self-requested a review May 16, 2023 05:34
@mmattel
mmattel force-pushed the new_occ_command branch from 32c6f98 to e47bf9e Compare May 16, 2023 10:28
@mmattel

mmattel commented May 16, 2023

Copy link
Copy Markdown
Contributor Author

@jvillafanez I have updated the example table according the changes you made in the core PR. Note that from my side the PR is ready for final review.

@jvillafanez jvillafanez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content-wise looks good. Just a couple of minor things.

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text looks OK, assuming that this is the command interface that is finally merged in core.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

3 participants