Implement batch action for inviting users to groups - #522
Conversation
a56d1c0 to
28d8f7d
Compare
88c7a35 to
6458fb0
Compare
c148b82 to
b5cbf52
Compare
6458fb0 to
d0e327f
Compare
4d9c6ab to
809d8f0
Compare
d0e327f to
cdc39cf
Compare
809d8f0 to
937c755
Compare
|
I put this into the Classic Server Team Board project, and mentioned some people for review. 1 JS test failed - I have no idea if that is a real fail. There is a conflict reported, so that n eeds to be sorted out. |
| continue; | ||
| } | ||
|
|
||
| // only add new users |
There was a problem hiding this comment.
it might be better to use a set instead of an array. The operation should be more clear too:
var s = new Set()
s.add(user) // guarantees uniqueness
There was a problem hiding this comment.
I tried it, unfortunately Sets do not support uniqueness with objects.
| var user = users[i].trim(); | ||
| var userAdded = false; | ||
|
|
||
| for (var j = 0; j < foundUsers.length; j++) { |
There was a problem hiding this comment.
same as above, it seems better to use a set instead of an array
3c6b2c8 to
f4e8ae5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Confirmed implemented in 0.7.0-rc.1 |
5 participants
Works towards https://github.com/owncloud/enterprise/issues/2865