refactor: remove occ integrity:sign-app / integrity:sign-core commands - #41712
Merged
Conversation
Code signing is a release/CI concern, not an operator action against a running instance, and the Checker::write*Signature() API was dead weight in the security-sensitive integrity subsystem. Remove the two signing commands, their tests, the signing-only Checker methods (createSignatureData/writeAppSignature/writeCoreSignature), the unused phpseclib RSA/X509 imports, and the now-orphaned signing key/cert fixtures. Verification is untouched: integrity:check-app / integrity:check-core and all Checker::verify* code (which delegates to the Verifier subsystem) remain fully functional. The shared generateHashes()/getFolderIterator() helpers stay. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
phil-davis
reviewed
Jul 22, 2026
Comment on lines
+51
to
+52
| * applications. For example the author of the application "calendar" would only | ||
| * receive a certificate only valid for this application. |
Contributor
There was a problem hiding this comment.
Suggested change
| * applications. For example the author of the application "calendar" would only | |
| * receive a certificate only valid for this application. | |
| * applications. For example, the author of the application "calendar" would only | |
| * receive a certificate that is valid for this application. |
The word "only" was repeated (that was already in the original text).
Not sure if it is worth bothering to adjust the grammar of this comment.
Contributor
Author
There was a problem hiding this comment.
Fixed in 1c68ffd — applied the suggestion: dropped the duplicated "only" and added the comma after "For example".
Addresses review feedback on #41712. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
phil-davis
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
occ integrity:sign-appandintegrity:sign-coreconsole commands and all signing-only code from the integrity subsystem:core/Command/Integrity/SignApp.phpandSignCore.phpand unregistered them incore/register_command.php(theCheckApp/CheckCoreverification commands stay).Checker(createSignatureData(),writeAppSignature(),writeCoreSignature()), the now-unusedphpseclib3RSA/PrivateKey/X509 imports, and rewrote the class docblock as verification-only. The sharedgenerateHashes()/getFolderIterator()helpers remain (used byverify()).testWrite*methods fromCheckerTest, plus the now-orphaned signing key/cert fixtures (SomeApp.{key,crt},core.{key,crt}).Verification is untouched —
integrity:check-app/integrity:check-coreand allChecker::verify*code (which delegates to the Verifier subsystem) remain fully functional.Related Issue
Motivation and Context
Code signing is a release/CI concern, not an operator action to perform against a running instance. The
Checker::write*Signature()API was effectively dead weight inside the security-sensitive integrity subsystem; removing it shrinks the attack/maintenance surface while leaving integrity verification intact.How Has This Been Tested?
tests/lib/IntegrityCheck/CheckerTest.php— 30/30 passtests/lib/IntegrityCheck/suite — 191/191 passocc listshows onlyintegrity:check-app/integrity:check-core;occ integrity:sign-core→ "Command not defined";occ integrity:check-coreruns clean (exit 0)git grepforwriteAppSignature|writeCoreSignature|createSignatureData|integrity:sign|SignApp|SignCore→ no dangling referencesTypes of changes
integrity:sign-app/integrity:sign-coreocc commands)Checklist:
🤖 Generated with Claude Code