fix: use an indepentant URL for checking internet connectivtiy - #41506
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
force-pushed
the
fix/internet-connectivity-check
branch
from
March 19, 2026 07:57
2493ca9 to
a9aa0d7
Compare
kw-ftaeger
reviewed
Mar 19, 2026
| /** | ||
| * The following URL is used to detect internet connectivity. | ||
| */ | ||
| 'internet_connectivity_detect_url' => 'https://detectportal.firefox.com/success.txt', |
Member
There was a problem hiding this comment.
Could this maybe be a list of multiple hostnames where at least one of them required to be reachable? This would allow to circumvent individual destination to be offline and therefore create friction by something the admin of a system doesn't control.
Contributor
Author
There was a problem hiding this comment.
for the sake of simplicity I'd like to keep it this way. In 12+y there was no need to ever change this url or even have it configurable. We should be save ;-)
DeepDiver1975
force-pushed
the
fix/internet-connectivity-check
branch
2 times, most recently
from
March 19, 2026 09:31
481fb5d to
2d56f53
Compare
jvillafanez
approved these changes
Apr 15, 2026
DeepDiver1975
force-pushed
the
fix/internet-connectivity-check
branch
from
April 15, 2026 09:43
2d56f53 to
b8471e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: