fix: perform SVG santitization on all file content which is pushed to… - #41433
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
force-pushed
the
fix/imagick-svg
branch
2 times, most recently
from
January 13, 2026 15:32
e2d94c5 to
91d27dc
Compare
DeepDiver1975
marked this pull request as draft
January 13, 2026 16:35
Contributor
Author
ToDo
|
DeepDiver1975
force-pushed
the
fix/imagick-svg
branch
from
January 15, 2026 08:50
91d27dc to
87487f4
Compare
DeepDiver1975
marked this pull request as ready for review
January 15, 2026 08:50
jvillafanez
reviewed
Jan 15, 2026
| */ | ||
| private function getResizedPreview($stream, $maxX, $maxY) { | ||
| # file content can be SVG - we need to sanitize it first | ||
| $content = \stream_get_contents($stream); |
Member
There was a problem hiding this comment.
I think we need a safety net here. We don't know the length of the stream, and it could potentially be GB size.
If sanitizing the SVG as stream isn't possible, maybe we can read up to a maximum of 10MB (or some configurable value) and don't generate the preview if the file is too big.
jvillafanez
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Imagick
Description
Bugfix: Apply SVG sanitization to all file content before using ImageMagick
Any file content is now sanitized for SVG threats before being processed by
ImageMagick, preventing potential security vulnerabilities.
How Has This Been Tested?
Types of changes
Checklist: