Skip to content

fix: proper error handling when deleting users/groups is failing - #41077

Merged
DeepDiver1975 merged 1 commit into
masterfrom
fix/js-dont-store-user-in-global-namespace
Nov 8, 2023
Merged

fix: proper error handling when deleting users/groups is failing#41077
DeepDiver1975 merged 1 commit into
masterfrom
fix/js-dont-store-user-in-global-namespace

Conversation

@DeepDiver1975

@DeepDiver1975 DeepDiver1975 commented Nov 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

In case of an error when deleting a user or a group no proper feedback was given to the user.

Bonus: fix undo on groups

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE
@update-docs

update-docs Bot commented Nov 8, 2023

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.
@DeepDiver1975
DeepDiver1975 force-pushed the fix/js-dont-store-user-in-global-namespace branch from eebc23c to bda43ea Compare November 8, 2023 11:57
@sonarqubecloud

sonarqubecloud Bot commented Nov 8, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication
@jvillafanez jvillafanez mentioned this pull request Nov 8, 2023
Closed
@jvillafanez

jvillafanez commented Nov 8, 2023

Copy link
Copy Markdown
Member

Found #41079 , but I don't think it's caused by this PR. We can fix it in a different PR. Other than that, the code looks fine to me.
@DeepDiver1975

DeepDiver1975 commented Nov 8, 2023

Copy link
Copy Markdown
Contributor Author

We can fix it in a different PR.

Reads like this needs to be fixed in some related but still untouched code segment. We can do a dedicated pr ...
@DeepDiver1975
DeepDiver1975 merged commit ba2d7ba into master Nov 8, 2023
@delete-merged-branch
delete-merged-branch Bot deleted the fix/js-dont-store-user-in-global-namespace branch November 8, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - To Review

2 participants

@DeepDiver1975 @jvillafanez