fix: use correct l10n folder when theme is enabled and apps_path is a… - #40607
Merged
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
force-pushed
the
fix/assert-themed-l10n-folder-to-be-folders
branch
2 times, most recently
from
January 30, 2023 13:14
ccd4dbc to
1808a64
Compare
IljaN
approved these changes
Jan 30, 2023
IljaN
left a comment
IljaN
left a comment
Contributor
There was a problem hiding this comment.
Not very knowledgeable around this parts of core, but LGMT 👍
Contributor
|
@DeepDiver1975 changelog? |
Contributor
Author
|
I also have one test case pending. Will finish tomorrow |
DeepDiver1975
force-pushed
the
fix/assert-themed-l10n-folder-to-be-folders
branch
from
February 2, 2023 07:30
1808a64 to
1141ca2
Compare
DeepDiver1975
force-pushed
the
fix/assert-themed-l10n-folder-to-be-folders
branch
from
February 6, 2023 13:59
1141ca2 to
8f928dc
Compare
Contributor
|
💥 Acceptance tests pipeline apiShareReshareToRoot2-mariadb10.2-php7.4 failed. The build has been cancelled. |
|
Kudos, SonarCloud Quality Gate passed! |
delete-merged-branch
Bot
deleted the
fix/assert-themed-l10n-folder-to-be-folders
branch
February 6, 2023 15:43
Contributor
|
Cannot confirm this fix. Details see https://github.com/owncloud/enterprise/issues/5633 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… symlink
Description
Due to magic path operations an instance could explode under following constellation:
/var/www/owncloud->/var/www/owncloud-10.12.13-crazy.long-nameMotivation and Context
How Has This Been Tested?
Types of changes
Checklist: