Skip to content

Fully initialize the FS in the cleanup command (upload folder is moun… - #40571

Merged
DeepDiver1975 merged 2 commits into
masterfrom
fix_chunk_cleanup_location
Jan 11, 2023
Merged

Fully initialize the FS in the cleanup command (upload folder is moun…#40571
DeepDiver1975 merged 2 commits into
masterfrom
fix_chunk_cleanup_location

Conversation

@jvillafanez

Copy link
Copy Markdown
Member

…ted)

Description

occ dav:cleanup-chunks command wasn't working when the chunk location wasn't the default. This was caused by a partial initialization of the FS (without mount points) even though the uploads location was mounted (not a regular folder)

Related Issue

https://github.com/owncloud/enterprise/issues/5498

Motivation and Context

Otherwise it isn't possible to remove obsolete chunks from the uploads directory via the occ command if a different location is configured.

How Has This Been Tested?

Followed steps described in the ticket

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE
@update-docs

update-docs Bot commented Jan 11, 2023

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jvillafanez
jvillafanez force-pushed the fix_chunk_cleanup_location branch from 9c3e66b to f2d2e57 Compare January 11, 2023 11:48
@sonarqubecloud

Copy link
Copy Markdown

@mrow4a mrow4a left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮‍💨

@DeepDiver1975
DeepDiver1975 merged commit b82bf9e into master Jan 11, 2023
@delete-merged-branch
delete-merged-branch Bot deleted the fix_chunk_cleanup_location branch January 11, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants