Skip to content

Emit share with user type - #40013

Merged
AlexAndBear merged 7 commits into
masterfrom
share-api-emit-share-with-user-type
Apr 25, 2022
Merged

Emit share with user type#40013
AlexAndBear merged 7 commits into
masterfrom
share-api-emit-share-with-user-type

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Apr 25, 2022 •
edited
Loading

Copy link
Copy Markdown

Description

Enhancement: Expose user type of share receiver in share api

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:
@AlexAndBear
AlexAndBear marked this pull request as ready for review April 25, 2022 09:32
@AlexAndBear AlexAndBear mentioned this pull request Apr 25, 2022
Closed
@owncloud owncloud deleted a comment from update-docs Bot Apr 25, 2022
@AlexAndBear
AlexAndBear force-pushed the share-api-emit-share-with-user-type branch from 6bbdca2 to 33a83a0 Compare April 25, 2022 10:01
kulmann
kulmann reviewed Apr 25, 2022
View reviewed changes
Comment thread apps/files_sharing/lib/AppInfo/Application.php Outdated
@AlexAndBear
AlexAndBear requested a review from kulmann April 25, 2022 11:50
@AlexAndBear AlexAndBear mentioned this pull request Apr 25, 2022
Closed
12 tasks
phil-davis
phil-davis approved these changes Apr 25, 2022
View reviewed changes

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I added share_with_user_type to 2 acceptance test scenarios to make sure that it really shows up.
@sonarqubecloud

sonarqubecloud Bot commented Apr 25, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication
@AlexAndBear
AlexAndBear merged commit 3efa63c into master Apr 25, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the share-api-emit-share-with-user-type branch April 25, 2022 13:27
This was referenced Apr 29, 2022
Open
Merged
@jesmrec jesmrec mentioned this pull request May 12, 2022
Open
@jnweiger

jnweiger commented May 17, 2022

Copy link
Copy Markdown
Contributor

Confirmed fixed in 10.10.0 RC2

/ocs/v1.php/apps/files_sharing/api/v1/shares?format=json has

  • normal users shares: share_type=0, share_with_user_type=0
  • guest users shares: share_type=0, share_with_user_type=1
  • group shares: share_type=1 and no element share_with_user_type

share_with_user_type_string was not added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@AlexAndBear @jnweiger @jvillafanez @phil-davis @kulmann