Skip to content

Add text to root element of breadcrumb - #39367

Merged
JammingBen merged 4 commits into
masterfrom
enterprise/issues/4807
Oct 27, 2021
Merged

Add text to root element of breadcrumb#39367
JammingBen merged 4 commits into
masterfrom
enterprise/issues/4807

Conversation

@JammingBen

@JammingBen JammingBen commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

Description

This makes it clear where the breadcrumb element is refering to.

Related Issue

Screenshots (if appropriate):

Before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE
@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline webUIComments-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33092/125/1

@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline webUIFileActionsMenu-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33092/153/1

Comment thread apps/files/js/filelist.js Outdated
@JammingBen
JammingBen force-pushed the enterprise/issues/4807 branch from a404266 to b09f08b Compare October 27, 2021 06:38
@owncloud owncloud deleted a comment from CLAassistant Oct 27, 2021
@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline apiFederationToShares1-latest-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33419/109/1

@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline webUIPersonalSetting-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33419/134/1

@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline apiSharingNotificationsToRoot-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33419/100/1

@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline apiWebdavUpload2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33419/99/1

@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline webUISharingAutocomp2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33419/141/1

@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline apiTags-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33419/81/1

@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline webUISharingIntUsers2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33419/145/1

@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline webUISharingExt2-git-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33419/158/1

@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline apiFederationToShares2-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33419/111/1

@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline apiWebdavLocks-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33419/88/1

@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline webUISharingIntGroup2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33421/143/1

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me - "All files" and "Deleted files" is shown according to the context.

@ownclouders

Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline apiSharePublicLink2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33423/72/1

@phil-davis

Copy link
Copy Markdown
Contributor

https://drone.owncloud.com/owncloud/core/33423/72/13
HTTP status was 503
<s:exception>Sabre\DAV\Exception\ServiceUnavailable</s:exception>
<s:message>Could not open file</s:message>

That's sad and unrelated. I see that CI has been restarted.

@sonarqubecloud

Copy link
Copy Markdown
@JammingBen
JammingBen merged commit 321c914 into master Oct 27, 2021
@delete-merged-branch
delete-merged-branch Bot deleted the enterprise/issues/4807 branch October 27, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants