Create new DB index and add new condition

[jvillafanez]

Description

speed up searches in the addressbook in large setups

Related Issue

https://github.com/owncloud/enterprise/issues/4655

Motivation and Context

How Has This Been Tested?

Manually tested with 2 federated servers with around 1000 users each.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[ownclouders]

💥 Acceptance tests pipeline apiFederationToShares1-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31350/113/1

[ownclouders]

💥 Acceptance tests pipeline apiFederationToShares1-10.6.0-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31354/115/1

[JammingBen]

LGTM code-wise.

SonarCloud complains about the code coverage though because the migration file is not tested. IMO migration files should not be unit-tested, but I've seen some (core-) apps do it...

[ownclouders]

💥 Acceptance tests pipeline apiFederationToShares1-latest-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31792/115/1

[ownclouders]

💥 Acceptance tests pipeline apiFederationToShares1-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31792/114/1

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

16.7% Coverage
0.0% Duplication

[mrow4a]

@jvillafanez isnt there already one #37152 ?

[jvillafanez]

The index isn't being used properly in that particular query. You can check some research in https://github.com/owncloud/enterprise/issues/4655#issuecomment-878239622

The checked performance is described in https://github.com/owncloud/enterprise/issues/4655#issuecomment-880052549

[mrow4a]

@jvillafanez in fact I proposed the index you have in this PR long time ago (#30195 (comment)) but it was rejected at a time , with prefered one also on value. I guess then we need both..

[jvillafanez]

Definitely we should have a usable index on the value, but the problems are the case insensitive search and the substring search. I don't think we can do much more without restricting the query, which would remove part of the current functionality, or adding new tables oriented to index this one.

[jvillafanez]

Rebased and tests added. The migration has been moved to the dav app.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication