Fix tab headers on small display ratio - #38653
Merged
Merged
Conversation
micbar
approved these changes
Apr 26, 2021
AlexAndBear
force-pushed
the
fix-tab-headers-on-small-display-ratio
branch
from
April 26, 2021 08:50
c3b5659 to
5c04546
Compare
Contributor
|
please add changelog |
Author
|
@micbar done |
AlexAndBear
marked this pull request as ready for review
April 26, 2021 08:52
hurradieweltgehtunter
previously requested changes
Apr 26, 2021
Contributor
There was a problem hiding this comment.
Hovering state of the tabs is wider than the un-hovered state which results in a little sideways glitch when hovering over the tabs.
font:weight: bold; makes the tab wider.
-> remove font-weight: bold;
or add font-weight: bold to unhovered state, too
AlexAndBear
force-pushed
the
fix-tab-headers-on-small-display-ratio
branch
from
April 27, 2021 07:21
5c04546 to
7653693
Compare
Author
|
@micbar @hurradieweltgehtunter @ChrisEdS since we refactored the whole tab headers look and feel, I request a new review |
ChrisEdS
approved these changes
Apr 27, 2021
ChrisEdS
left a comment
ChrisEdS
left a comment
There was a problem hiding this comment.
Tested on Chrome. Looks good to me!
|
Kudos, SonarCloud Quality Gate passed!
|
delete-merged-branch
Bot
deleted the
fix-tab-headers-on-small-display-ratio
branch
April 27, 2021 12:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixing tabheader misalign issue on small display ratio, also adjust selected style which is matching better now to other elements (for example left sidebar)
Issue reported by @ChrisEdS
Tested on:
Screenshots (if appropriate):
Before:
After:
(Normal view mode)
(Shrinked view mode)
Types of changes
Checklist: