Prevent getting a version expiry list when no versions available - #38390
Merged
Conversation
jvillafanez
approved these changes
Feb 10, 2021
jvillafanez
left a comment
jvillafanez
left a comment
Member
There was a problem hiding this comment.
I don't expect a really big list of versions (maybe 100 at most), so the performance impact should be minimal. No real need to change anything.
| $expiration = self::getExpiration(); | ||
|
|
||
| if ($expiration->shouldAutoExpire()) { | ||
| if ($expiration->shouldAutoExpire() && \count($versions) > 0) { |
Member
There was a problem hiding this comment.
!empty($versions) might be faster
|
Kudos, SonarCloud Quality Gate passed!
|
phil-davis
approved these changes
Feb 11, 2021
AlexAndBear
approved these changes
Feb 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previous to this little fix, when getting a version expiry list with an empty
$versionarray, OC ran into an error. Not a critical one, but still not nice and spams theowncloud.logfile.How does this happen?
Versions of a file expire at a certain point of time. When a version is added to a file, an expiry command is scheduled via cronjob. Eventually the cronjob runs and will expire (=delete) the version of this file. But it is also possible to clean up all versions in between those two actions, for instance with the command
occ version:cleanup. When the cronjob runs afterwards, no versions will be available to expire -> error.Steps to reproduce:
occ version:cleanup.occ system:cron.owncloud.logfile, it should've logged the error:Trying to access array offset on value of type bool at /path/to/your/owncloud.Related Issue
Types of changes
Checklist: