let resharer to send an e-mail for public link - #36393
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36393 +/- ##
=========================================
Coverage 64.87% 64.87%
- Complexity 19797 19798 +1
=========================================
Files 1272 1272
Lines 74748 74748
Branches 1309 1309
=========================================
Hits 48495 48495
Misses 25867 25867
Partials 386 386
Continue to review full report at Codecov.
|
phil-davis
left a comment
There was a problem hiding this comment.
Looks good. Push a changelog entry here also.
I will look at adding some extra scenarios (issue #36388 ) that will cover a couple more combinations of this.
afe1435 to
7a304fe
Compare
|
Changelog entry added. |
|
@phil-davis Should we wait for additional tests to merge? |
|
@karakayasemi I tried to demo it. |
|
@micbar I tested again, in my environment it is working as expected. We worked with BDD approach on this issue. There is an acceptance test scenario that simulates related scenario. |
Description
let resharer to send an e-mail for public link.
Related Issue
Motivation and Context
Currently, sending an e-mail when creating public links from received shares is impossible. This PR will fix this issue.
How Has This Been Tested?
Manually with issues scenario. Also, acceptance tests are ready.
Types of changes
Checklist: