Skip to content

[master] fix chunked upload for guest app - #31618

Merged
phil-davis merged 2 commits into
masterfrom
port_fix_chunked_upload_for_guest_app
Jun 5, 2018
Merged

[master] fix chunked upload for guest app#31618
phil-davis merged 2 commits into
masterfrom
port_fix_chunked_upload_for_guest_app

Conversation

@IljaN

@IljaN IljaN commented Jun 1, 2018

Copy link
Copy Markdown
Contributor

Forward port of #31596
@IljaN IljaN mentioned this pull request Jun 1, 2018
Merged
9 tasks
@IljaN IljaN self-assigned this Jun 1, 2018
@IljaN IljaN added this to the development milestone Jun 1, 2018
@IljaN
IljaN requested a review from PVince81 June 1, 2018 15:53
@IljaN
IljaN force-pushed the port_fix_chunked_upload_for_guest_app branch from 413516a to 1886eae Compare June 1, 2018 16:12
@codecov

codecov Bot commented Jun 1, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #31618 into master will increase coverage by 0.29%.
The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #31618      +/-   ##
============================================
+ Coverage     62.54%   62.84%   +0.29%     
- Complexity    18373    18378       +5     
============================================
  Files          1151     1151              
  Lines         69060    69069       +9     
  Branches       1260     1260              
============================================
+ Hits          43193    43405     +212     
+ Misses        25498    25295     -203     
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 52.39% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.04% <90%> (+0.33%) 18378 <2> (+5) ⬆️
Impacted Files Coverage Δ Complexity Δ
...les/Cache/Wrapper/ReadOnlyCachePermissionsMask.php 94.73% <90%> (-5.27%) 9 <2> (+5)
lib/private/Share/Share.php 67.14% <0%> (+0.06%) 507% <0%> (ø) ⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (+0.48%) 68% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 97.57% <0%> (+0.9%) 107% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaWriter.php 93.75% <0%> (+1.04%) 34% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaManager.php 91.22% <0%> (+1.75%) 17% <0%> (ø) ⬇️
lib/private/AllConfig.php 92% <0%> (+2.4%) 45% <0%> (ø) ⬇️
lib/private/Repair/RepairInvalidShares.php 97.26% <0%> (+2.73%) 17% <0%> (ø) ⬇️
lib/private/Repair/RepairMismatchFileCachePath.php 85.2% <0%> (+3.6%) 49% <0%> (ø) ⬇️
lib/private/DB/ConnectionFactory.php 82.19% <0%> (+4.1%) 20% <0%> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc018b...7447c09. Read the comment docs.
PVince81
PVince81 approved these changes Jun 1, 2018
View reviewed changes

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@PVince81 PVince81 assigned PVince81 and unassigned IljaN Jun 4, 2018
This was referenced Jun 4, 2018
Closed
Merged
@PVince81
PVince81 force-pushed the port_fix_chunked_upload_for_guest_app branch from 1886eae to 7447c09 Compare June 4, 2018 12:31
@PVince81

PVince81 commented Jun 4, 2018

Copy link
Copy Markdown
Contributor

Removed empty line at end of file and squashed into the first commit.
@phil-davis
phil-davis merged commit db8089d into master Jun 5, 2018
@phil-davis
phil-davis deleted the port_fix_chunked_upload_for_guest_app branch June 5, 2018 06:28
@phil-davis phil-davis mentioned this pull request Jun 5, 2018
Merged
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock

lock Bot commented Jul 31, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.