Skip to content

refactor: share more code - #910

Merged
metacosm merged 1 commit into
mainfrom
test
Feb 4, 2022
Merged

refactor: share more code#910
metacosm merged 1 commit into
mainfrom
test

Conversation

@metacosm

@metacosm metacosm commented Feb 4, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@metacosm metacosm self-assigned this Feb 4, 2022
@metacosm
metacosm requested a review from csviri February 4, 2022 14:09
@sonarqubecloud

sonarqubecloud Bot commented Feb 4, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication
@andreaTP

andreaTP commented Feb 4, 2022

Copy link
Copy Markdown
Collaborator

LGTM, thanks! 👍
@metacosm

metacosm commented Feb 4, 2022

Copy link
Copy Markdown
Collaborator Author

LGTM, thanks! 👍

No, thank you for the initial work! 😁
csviri
csviri approved these changes Feb 4, 2022
View reviewed changes

@csviri csviri left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@metacosm
metacosm merged commit 817f8ca into main Feb 4, 2022
@metacosm
metacosm deleted the test branch February 4, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@metacosm @andreaTP @csviri