feat: field selectors support for InformerEventSource - #2835
Merged
Conversation
csviri
marked this pull request as draft
June 19, 2025 10:13
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Collaborator
Author
|
closes #2813 |
xstefank
approved these changes
Jun 19, 2025
csviri
marked this pull request as ready for review
June 20, 2025 07:19
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
Collaborator
Author
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
xstefank
approved these changes
Jun 20, 2025
| informer = | ||
| @Informer( | ||
| withFields = | ||
| @Field(field = "type", value = FieldSelectorTestReconciler.MY_SECRET_TYPE))) |
Collaborator
There was a problem hiding this comment.
This seems a little strange to me to read. Maybe "name" or "key" so it's not @Field(field = ... but of course this is just recommendation so feel free to discard it.
Collaborator
Author
There was a problem hiding this comment.
Yes, it is a bit smelly.
Alternatively, we could have:
@FieldSelector(field="type", value="value", negated=false)
So there would not be with and without fields in @Informer just a list of @FieldSelector.
We might want to have similar api for java api for informers.
Collaborator
Author
There was a problem hiding this comment.
refactored it to a more explicit model, PTAL
metacosm
requested changes
Jun 20, 2025
metacosm
approved these changes
Jun 20, 2025
csviri
added a commit
that referenced
this pull request
Jun 26, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
added a commit
that referenced
this pull request
Jul 1, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
added a commit
that referenced
this pull request
Aug 1, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
added a commit
that referenced
this pull request
Aug 11, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
added a commit
that referenced
this pull request
Aug 21, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
added a commit
that referenced
this pull request
Sep 2, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
added a commit
that referenced
this pull request
Sep 24, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
added a commit
that referenced
this pull request
Oct 7, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
This was referenced Oct 10, 2025
Closed
csviri
added a commit
that referenced
this pull request
Oct 14, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
added a commit
that referenced
this pull request
Oct 18, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
added a commit
that referenced
this pull request
Oct 23, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
added a commit
that referenced
this pull request
Nov 20, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
added a commit
that referenced
this pull request
Nov 25, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
dongjoon-hyun
added a commit
to apache/spark-kubernetes-operator
that referenced
this pull request
Dec 10, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `operator-sdk` to 5.2.1 ### Why are the changes needed? To bring the latest improvements and bug fixes: - https://javaoperatorsdk.io/blog/2025/11/25/version-5.2-released/ - https://github.com/operator-framework/java-operator-sdk/releases/tag/v5.2.1 - https://github.com/operator-framework/java-operator-sdk/releases/tag/v5.2.0 - operator-framework/java-operator-sdk#2937 - operator-framework/java-operator-sdk#2934 - operator-framework/java-operator-sdk#2917 - operator-framework/java-operator-sdk#2835 ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #424 from dongjoon-hyun/SPARK-54671. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros a_meszaros@apple.com
closes #2813