Skip to content

test: add test for urlstrings usage in node:fs - #49471

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
LiviaMedeiros:test-fs-whatwg-urlstring
Sep 5, 2023
Merged

test: add test for urlstrings usage in node:fs#49471
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
LiviaMedeiros:test-fs-whatwg-urlstring

Conversation

@LiviaMedeiros

@LiviaMedeiros LiviaMedeiros commented Sep 3, 2023

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 3, 2023
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53707/
aduh95
aduh95 approved these changes Sep 3, 2023
View reviewed changes
Comment thread test/parallel/test-fs-whatwg-url.js Outdated
Comment on lines +86 to +88
// Test that strings are interpreted as paths and not as URL
// Please avoid testing fs.rmdir('file:') or using it as cleanup
if (!common.isWindows) {

@aduh95 aduh95 Sep 3, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we put it in the else block just above?
This was referenced Sep 4, 2023
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53741/
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53743/
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Sep 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 5, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 21759bd into nodejs:main Sep 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in 21759bd
This was referenced Sep 6, 2023
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@LiviaMedeiros @ruyadorno
test: add test for urlstrings usage in node:fs
34c1741 
PR-URL: #49471
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

4 participants

@LiviaMedeiros @nodejs-github-bot @lpinca @aduh95