Skip to content

test: use tmpdir.resolve() in various tests #3 - #49136

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-tmpdir-resolve-five
Aug 21, 2023
Merged

test: use tmpdir.resolve() in various tests #3#49136
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:test-tmpdir-resolve-five

Conversation

@LiviaMedeiros

@LiviaMedeiros LiviaMedeiros commented Aug 13, 2023

Copy link
Copy Markdown
Member

Extracted from: #49079
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to Node.js documentation. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. node-api Issues and PRs related to Node-API. report Issues and PRs related to Node.js diagnostic reports. test Issues and PRs related to Node.js core tests and test infrastructure. tools Issues and PRs related to the tools directory. labels Aug 13, 2023
@LiviaMedeiros LiviaMedeiros removed doc Issues and PRs related to Node.js documentation. tools Issues and PRs related to the tools directory. addons Issues and PRs related to native addons. async_hooks Issues and PRs related to the async hooks subsystem. node-api Issues and PRs related to Node-API. esm Issues and PRs related to the ECMAScript Modules implementation. report Issues and PRs related to Node.js diagnostic reports. labels Aug 13, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53371/
@github-actions github-actions Bot mentioned this pull request Aug 17, 2023
Open
26 tasks
@LiviaMedeiros LiviaMedeiros added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 17, 2023
@github-actions github-actions Bot mentioned this pull request Aug 18, 2023
Open
32 tasks
@LiviaMedeiros LiviaMedeiros added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 21, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 052434a into nodejs:main Aug 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in 052434a
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@LiviaMedeiros @UlisesGascon
test: use tmpdir.resolve()
e391f4b 
PR-URL: #49136
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

3 participants

@LiviaMedeiros @nodejs-github-bot @lpinca