Skip to content

deps: update ada to 2.4.0 - #47922

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-ada
May 9, 2023
Merged

deps: update ada to 2.4.0#47922
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-ada

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented May 8, 2023 •
edited by anonrig
Loading

Copy link
Copy Markdown
Collaborator

This is an automated update of ada to 2.4.0.

Fixes #47894
@nodejs-github-bot nodejs-github-bot added the dependencies PRs that add, update, or configure Node.js dependencies. label May 8, 2023
@nodejs-github-bot

nodejs-github-bot commented May 8, 2023 •
edited by anonrig
Loading

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/url
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 8, 2023
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels May 8, 2023
@github-actions

github-actions Bot commented May 8, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.
@anonrig

anonrig commented May 8, 2023

Copy link
Copy Markdown
Member

cc @RaisinTen @bnoordhuis @tniessen
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2023
@nodejs-github-bot

nodejs-github-bot commented May 8, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51703/
@anonrig anonrig mentioned this pull request May 8, 2023
Closed
@github-actions github-actions Bot mentioned this pull request May 9, 2023
Open
29 tasks
RaisinTen
RaisinTen approved these changes May 9, 2023
View reviewed changes

@RaisinTen RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label May 9, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 9, 2023
@nodejs-github-bot
nodejs-github-bot merged commit a6ad5d8 into main May 9, 2023
@nodejs-github-bot

nodejs-github-bot commented May 9, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in a6ad5d8
@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-ada branch May 9, 2023 15:53
@github-actions github-actions Bot mentioned this pull request May 10, 2023
Open
25 tasks
targos pushed a commit that referenced this pull request May 12, 2023
@nodejs-github-bot @targos
deps: update ada to 2.4.0
c2b14b4 
PR-URL: #47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request May 15, 2023
Merged
@anonrig anonrig mentioned this pull request Jun 5, 2023
Closed
19 tasks
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.4.0
461c1e9 
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot @danielleadams
deps: update ada to 2.4.0
81b514d 
PR-URL: #47922
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dependencies PRs that add, update, or configure Node.js dependencies. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

6 participants

@nodejs-github-bot @anonrig @lemire @lpinca @RaisinTen @danielleadams