doc: Fix params names - #47853
Merged
Merged
Conversation
nodejs-github-bot
added
doc
lpinca
approved these changes
May 4, 2023
HarshithaKP
approved these changes
May 5, 2023
debadree25
added
author ready
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47853 ✔ Done loading data for nodejs/node/pull/47853 ----------------------------------- PR info ------------------------------------ Title doc: Fix params names (#47853) Author Dmitry Semigradsky (@Semigradsky) Branch Semigradsky:patch-2 -> nodejs:main Labels doc, stream, author ready Commits 2 - doc: fix params names - doc: capitalize the first characters Committers 1 - Dmitry Semigradsky PR-URL: https://github.com/nodejs/node/pull/47853 Reviewed-By: Luigi Pinca Reviewed-By: Harshitha K P ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47853 Reviewed-By: Luigi Pinca Reviewed-By: Harshitha K P -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 04 May 2023 09:20:04 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47853#pullrequestreview-1413833963 ✔ - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/47853#pullrequestreview-1414637380 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47853 From https://github.com/nodejs/node * branch refs/pull/47853/merge -> FETCH_HEAD ✔ Fetched commits as 351bf775e169..c98a66aec052 -------------------------------------------------------------------------------- [main dbf132fa20] doc: fix params names Author: Dmitry Semigradsky Date: Thu May 4 18:10:33 2023 +0300 1 file changed, 3 insertions(+), 3 deletions(-) [main a8abd4e801] doc: capitalize the first characters Author: Dmitry Semigradsky Date: Thu May 4 18:12:05 2023 +0300 1 file changed, 3 insertions(+), 3 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/4903281450 |
debadree25
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 281ef80 |
targos
pushed a commit
that referenced
this pull request
May 12, 2023
PR-URL: #47853 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47853 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47853 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.