Skip to content

feat: allow selecting Node.js for npm releases - #34

Open
elrrrrrrr wants to merge 1 commit into
node-modules:masterfrom
elrrrrrrr:feat/npm-release-node-version-input
Open

feat: allow selecting Node.js for npm releases#34
elrrrrrrr wants to merge 1 commit into
node-modules:masterfrom
elrrrrrrr:feat/npm-release-node-version-input

Conversation

@elrrrrrrr

@elrrrrrrr elrrrrrrr commented Jul 13, 2026

Copy link
Copy Markdown

Summary

  • add a node-version input to the reusable npm release workflow
  • preserve lts/* as the default for existing callers
  • allow maintenance branches to pin a compatible Node.js major

This will let cnpmcore 3.x publish with Node.js 20 while leaving other callers unchanged.

Summary by CodeRabbit

  • Chores
    • Added support for selecting the Node.js version used during package release workflows.
    • Defaults to the current long-term support version when no version is specified.
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 38db1c1d-d771-40f9-b591-e48ecbe96cbe

📥 Commits

Reviewing files that changed from the base of the PR and between c0c86f6 and 10a7f98.

📒 Files selected for processing (1)
  • .github/workflows/npm-release.yml

📝 Walkthrough

Walkthrough

The reusable npm release workflow adds a node-version input defaulting to lts/* and uses that input when configuring the Node.js setup action.

Changes

npm release workflow

Layer / File(s) Summary
Node.js version input and setup
.github/workflows/npm-release.yml
Adds a string node-version workflow input with an lts/* default and passes it to actions/setup-node.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: making the npm release workflow's Node.js version configurable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant