Skip to content

fix(core): don't hijack Ctrl+F in editors or behind modals - #63541

Merged
pringelmann merged 2 commits into
masterfrom
fix/63409/unified-search-hotkey-guards
Aug 26, 2026
Merged

fix(core): don't hijack Ctrl+F in editors or behind modals#63541
pringelmann merged 2 commits into
masterfrom
fix/63409/unified-search-hotkey-guards

Conversation

@pringelmann

@pringelmann pringelmann commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Unified search bound its own keydown listener that never checked the event target or open modals, so Ctrl+F inside a Text document opened search instead of the browser's find bar. useHotKey already guards both, so this uses it instead of duplicating that logic in core.

Behaviour changes

  • Ctrl+F in an editor or input now goes to the browser. Same behind an open modal.
  • Ctrl+K works again on /settings/users, /settings/apps and /apps/deck. It was checking the Ctrl+F opt-out, which nothing on that list uses for Ctrl+K, so Firefox took the key. Pre-existing bug.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes (no visual change)
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (tests, reviewed by me)
@pringelmann
pringelmann requested a review from a team as a code owner August 24, 2026 14:41
@pringelmann
pringelmann requested review from kristian-zendato, skjnldsv and sorbaugh and removed request for a team August 24, 2026 14:41
@pringelmann pringelmann self-assigned this Aug 24, 2026
@pringelmann
pringelmann requested a review from susnux August 24, 2026 14:41
@pringelmann pringelmann added this to the Nextcloud 35 milestone Aug 24, 2026
@pringelmann

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@pringelmann

Copy link
Copy Markdown
Contributor Author

/compile rebase

@nextcloud-command
nextcloud-command force-pushed the fix/63409/unified-search-hotkey-guards branch from f63b5dc to 817fd75 Compare August 24, 2026 16:36
@skjnldsv skjnldsv mentioned this pull request Aug 25, 2026
@pringelmann
pringelmann requested a review from CarlSchwan August 25, 2026 17:05
@pringelmann

Copy link
Copy Markdown
Contributor Author

/compile rebase

@susnux

susnux commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/backport to stable35

pringelmann and others added 2 commits August 25, 2026 17:40
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-command force-pushed the fix/63409/unified-search-hotkey-guards branch from 817fd75 to 5e26b1e Compare August 25, 2026 17:43
@pringelmann
pringelmann merged commit 83130ab into master Aug 26, 2026
194 checks passed
@pringelmann
pringelmann deleted the fix/63409/unified-search-hotkey-guards branch August 26, 2026 08:56
@backportbot

backportbot Bot commented Aug 26, 2026

Copy link
Copy Markdown

The backport to stable34 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable34
git pull origin stable34

# Create the new backport branch
git checkout -b backport/63541/stable34

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fe4fae0e 5e26b1ee

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/63541/stable34

Error: Failed to check for changes with origin/stable34: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment