test(db): replace addToAssertionCount checkbox tests in DB - #60750
Open
miaulalala wants to merge 1 commit into
Open
test(db): replace addToAssertionCount checkbox tests in DB#60750miaulalala wants to merge 1 commit into
miaulalala wants to merge 1 commit into
Conversation
miaulalala
force-pushed
the
fix/noid/checkbox-tests-db
branch
from
May 26, 2026 21:30
5e1c6e2 to
de80a8a
Compare
Contributor
Author
|
/backport to stable34 |
miaulalala
marked this pull request as ready for review
May 27, 2026 16:31
miaulalala
requested review from
ArtificialOwl,
icewind1991,
leftybournes and
provokateurin
and removed request for
a team
May 27, 2026 16:31
…ormAssertions and real assertions Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
miaulalala
force-pushed
the
fix/noid/checkbox-tests-db
branch
from
June 24, 2026 11:05
de80a8a to
f8e8cbf
Compare
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MigratorTest: add#[DoesNotPerformAssertions]to 5 tests that verify migrations run without throwing; refactortestInsertAfterUpgradeto useexpectExceptioninstead of a try/catch checkbox; replaceaddToAssertionCountintestNotNullEmptyValuesFailOraclewith a real assertion on the insert return valueQueryBuilderTest: remove two unreachableaddToAssertionCount(1)calls from catch blocks intestGetLastInsertId(thefail()in each try block already handles the no-exception path)Part of a broader effort to eliminate checkbox tests and replace them with proper PHPUnit 11 semantics.
Test plan
NOCOVERAGE=1 ./autotest.sh sqlite tests/lib/DB/MigratorTest.phpNOCOVERAGE=1 ./autotest.sh sqlite tests/lib/DB/QueryBuilder/QueryBuilderTest.php🤖 Generated with Claude Code