Skip to content

perf: Allow filtering the directory content by mimetype - #57891

Merged
CarlSchwan merged 2 commits into
masterfrom
carl/getDirectoryContent-mimetypefilter
Feb 12, 2026
Merged

perf: Allow filtering the directory content by mimetype#57891
CarlSchwan merged 2 commits into
masterfrom
carl/getDirectoryContent-mimetypefilter

Conversation

@CarlSchwan

@CarlSchwan CarlSchwan commented Jan 28, 2026

Copy link
Copy Markdown
Member

Summary

Likely too late for 33

Optimize a bit the /ocs/v2.php/apps/files/api/v1/folder-tree as it means we have less entry to fetch which takes around 30s to execute on prod

image

TODO

  • ...

Checklist

@CarlSchwan CarlSchwan added this to the Nextcloud 34 milestone Jan 28, 2026
@CarlSchwan CarlSchwan self-assigned this Jan 28, 2026
@CarlSchwan
CarlSchwan requested a review from a team as a code owner January 28, 2026 22:56
@CarlSchwan
CarlSchwan requested review from ArtificialOwl, come-nc, leftybournes and sorbaugh and removed request for a team January 28, 2026 22:56
@CarlSchwan
CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch 2 times, most recently from 2179cf1 to 5fe15da Compare January 29, 2026 10:04
@CarlSchwan
CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from 5fe15da to c3eba5b Compare January 29, 2026 10:13
@CarlSchwan
CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch 2 times, most recently from b554ad8 to ec2a77e Compare January 29, 2026 10:45
Comment thread lib/private/Files/View.php
Comment thread lib/public/Files/Cache/ICache.php Outdated
Comment thread lib/public/Files/Folder.php Outdated
Comment thread lib/public/Files/Cache/ICache.php Outdated
@CarlSchwan
CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from ec2a77e to e963419 Compare January 29, 2026 11:22
Comment thread lib/private/Files/View.php Outdated
Comment thread lib/private/Files/View.php Outdated
Comment thread lib/public/Files/Cache/ICache.php Outdated
Comment thread lib/public/Files/Folder.php Outdated
@CarlSchwan
CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from e963419 to b8a657b Compare January 29, 2026 11:58
Comment thread lib/private/Files/View.php Outdated
Comment thread lib/private/Files/View.php
@CarlSchwan
CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from b8a657b to e01e2ec Compare January 29, 2026 13:10
Comment thread lib/private/Files/View.php
@CarlSchwan
CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from e01e2ec to 084ef83 Compare January 29, 2026 13:44

@provokateurin provokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I found some more 🙈

Comment thread apps/files/lib/Controller/ApiController.php Outdated
Comment thread autotest.sh Outdated
Comment thread lib/private/Files/Filesystem.php Outdated
Comment thread lib/private/Files/Filesystem.php Outdated

@provokateurin provokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that it took so many rounds 😅

@CarlSchwan

Copy link
Copy Markdown
Member Author

Sorry that it took so many rounds 😅

Thanks for the quality review :)

@CarlSchwan
CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from ce34d55 to 41d052e Compare February 4, 2026 11:54
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
CarlSchwan force-pushed the carl/getDirectoryContent-mimetypefilter branch from 3d5316b to edd37d3 Compare February 11, 2026 23:36
@CarlSchwan
CarlSchwan merged commit d35773b into master Feb 12, 2026
193 checks passed
@CarlSchwan
CarlSchwan deleted the carl/getDirectoryContent-mimetypefilter branch February 12, 2026 00:22
@nextcloud-bot nextcloud-bot mentioned this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants