[stable33] feat: perform share mount validation on share instead of on mount - #57727
Closed
backportbot[bot] wants to merge 5 commits into
Closed
[stable33] feat: perform share mount validation on share instead of on mount#57727backportbot[bot] wants to merge 5 commits into
backportbot[bot] wants to merge 5 commits into
Conversation
backportbot
Bot
requested review from
ArtificialOwl,
CarlSchwan,
artonge,
icewind1991 and
salmart-dev
and removed request for
a team
January 22, 2026 12:58
Signed-off-by: Robin Appelman <robin@icewind.nl>
…e positives Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
approved these changes
Jan 22, 2026
nickvergessen
requested changes
Jan 22, 2026
nickvergessen
left a comment
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Currently breaking Talk/ folder replacements unexpectingly.
So blocking until this is clarified:
nextcloud/spreed#16717
Merged
Contributor
|
This seems to also break tests locally (the specific test case does not matter I see this everywhere):
|
Merged
This was referenced Feb 11, 2026
Merged
Merged
Contributor
|
Given that this got merged #57822, this PR can be closed, right @icewind1991 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #57295