Skip to content

use LazyUser in DefaultShareProvider - #33581

Merged
blizzz merged 2 commits into
masterfrom
share-lazy-user
Jun 17, 2024
Merged

use LazyUser in DefaultShareProvider#33581
blizzz merged 2 commits into
masterfrom
share-lazy-user

Conversation

@icewind1991

@icewind1991 icewind1991 commented Aug 17, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Robin Appelman robin@icewind.nl
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 17, 2022
@icewind1991 icewind1991 added this to the Nextcloud 25 milestone Aug 17, 2022
@icewind1991
icewind1991 requested review from a team, ArtificialOwl, PVince81 and come-nc and removed request for a team August 17, 2022 12:30
PVince81
PVince81 approved these changes Aug 17, 2022
View reviewed changes

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
artonge
artonge reviewed Aug 17, 2022
View reviewed changes
Comment thread lib/private/Share20/DefaultShareProvider.php
@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
Merged
@nickvergessen

nickvergessen commented Aug 18, 2022

Copy link
Copy Markdown
Member

Tests: 4297, Assertions: 15882, Failures: 11, Skipped: 28, Risky: 1.

DB unit tests are failing
@PVince81

PVince81 commented Aug 23, 2022

Copy link
Copy Markdown
Member

@icewind1991 please fix the tests
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
@PVince81 PVince81 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 16, 2022
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz added this to the Nextcloud 27 milestone Mar 9, 2023
@szaimen

szaimen commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

@icewind1991 can you please fix the tests?
This was referenced May 3, 2023
Merged
Closed
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 9, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@icewind1991 @come-nc
use LazyUser in DefaultShareProvider
7f6a891 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@come-nc

come-nc commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

Rebased and fixed conflicts
@come-nc
fix(tests): Fix tests with new LazyUser usage in DefaultShareProvider
de6bb33 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@blizzz
blizzz merged commit 2bc949d into master Jun 17, 2024
@blizzz
blizzz deleted the share-lazy-user branch June 17, 2024 20:53
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress performance 🚀

9 participants

@icewind1991 @nickvergessen @PVince81 @szaimen @come-nc @artonge @CarlSchwan @blizzz @skjnldsv