Upgrade eslint-config to v6.0.0 - #28019
Closed
Pytal wants to merge 3 commits into
Closed
Conversation
Pytal
requested review from
CarlSchwan,
ChristophWurst,
GretaD,
artonge,
blizzz,
danxuliu,
julien-nc,
juliusknorr,
kesselb,
skjnldsv,
st3iny and
szaimen
July 16, 2021 21:52
artonge
approved these changes
Jul 19, 2021
artonge
left a comment
artonge
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the breath of fresh air space !
- add required dev dependencies Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
szaimen
removed their request for review
July 19, 2021 21:33
Member
|
Needs a rebase after #28115 🙈 |
skjnldsv
requested changes
Jul 23, 2021
skjnldsv
left a comment
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Eslint-config v6 requires webpack 5.
https://github.com/nextcloud/eslint-config/blob/70e5f6d03d4d606c394be1dd7c570fef4497d681/package.json#L22
Merged
Merged
Member
|
Seems like this has been done somewhere else already, therefore closing ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending migration to
@nextcloud/webpack-vue-configand webpack 5Upgrade @nextcloud/eslint-config to v6.0.0, latest major :)