Skip to content

add: Android 13 themed icon - #170

Closed
sadorowo wants to merge 5 commits into
nextcloud:masterfrom
sadorowo:master
Closed

add: Android 13 themed icon#170
sadorowo wants to merge 5 commits into
nextcloud:masterfrom
sadorowo:master

Conversation

@sadorowo

@sadorowo sadorowo commented Jun 9, 2024

Copy link
Copy Markdown
Contributor

Fixes #169

Previews:

non-themed themed
image image

How to enable themed icon:

Warning

These instructions are for AOSP-based ROMs only.

  1. Ensure you are on Android 13 or higher.
  2. Long hold empty space on your home screen and select 'Wallpapers & style'.
  3. Scroll down and enable 'Themed icons':
    image
sadorowo added 2 commits June 9, 2024 13:52
Signed-off-by: sadorowo <me@sador.me>
Signed-off-by: sadorowo <me@sador.me>
@binsky08 binsky08 added this to the v1.5.1 milestone Jun 9, 2024
@binsky08
binsky08 self-requested a review October 17, 2024 16:15

@binsky08 binsky08 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the pull requests. It looks good in general.

Adaptive icons are only supported from api level 26. Since passman-android currently also supports devices from api level 21, it still needs the legacy icon as a fallback.

I've the commits already locally, but I'm not allowed to edit this pr. So may I'll add them later or so. It's fine for now.

@sadorowo

Copy link
Copy Markdown
Contributor Author

Hi, thanks for the pull requests. It looks good in general.

Adaptive icons are only supported from api level 26. Since passman-android currently also supports devices from api level 21, it still needs the legacy icon as a fallback.

I've the commits already locally, but I'm not allowed to edit this pr. So may I'll add them later or so. It's fine for now.

Screenshot_20250118-214933

weird, maintainers can edit PRs

@binsky08

binsky08 commented Jan 18, 2025

Copy link
Copy Markdown
Collaborator

Hi, thanks for the pull requests. It looks good in general.
Adaptive icons are only supported from api level 26. Since passman-android currently also supports devices from api level 21, it still needs the legacy icon as a fallback.
I've the commits already locally, but I'm not allowed to edit this pr. So may I'll add them later or so. It's fine for now.

Screenshot_20250118-214933

weird, maintainers can edit PRs

yes, but I think I don't have the maintainer role

or I just failed somehow :D

@sadorowo

Copy link
Copy Markdown
Contributor Author

Hi, thanks for the pull requests. It looks good in general.
Adaptive icons are only supported from api level 26. Since passman-android currently also supports devices from api level 21, it still needs the legacy icon as a fallback.
I've the commits already locally, but I'm not allowed to edit this pr. So may I'll add them later or so. It's fine for now.

Screenshot_20250118-214933
weird, maintainers can edit PRs

yes, but I think I don't have the maintainer role

or I just failed somehow :D

i've added you as a collaborator on my fork

@sadorowo sadorowo closed this by deleting the head repository May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants