feat: replace original Authentication header after HaProxy auth - #33
Merged
Conversation
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Member
|
edited: I think these changes should go also to |
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
…ization` Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
bigcat88
marked this pull request as ready for review
July 23, 2024 10:37
bigcat88
approved these changes
Jul 23, 2024
bigcat88
approved these changes
Jul 23, 2024
bigcat88
added a commit
to nextcloud/app_api
that referenced
this pull request
Jul 23, 2024
…334) Ref: nextcloud/docker-socket-proxy#33 --------- Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com> Signed-off-by: Alexander Piskun <bigcat88@icloud.com> Co-authored-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is backward compatible change, since AppAPI 3.0.0 we'll save the original request's basic Authentication header to
X-Original-Authentication, and in Docker Socket Proxy here we replace it to the default Authentication header to pass it further to the service behind HaProxy.