fix(filesystem): deal with win32 long paths when recursively removing folders - #9634
Merged
Merged
Conversation
nilsding
requested review from
Aiiaiiio,
camilasan,
i2h3 and
mgallien
as code owners
March 16, 2026 12:40
Member
Author
|
/backport to stable-33.0 |
Member
Author
|
/backport to stable-4.0 |
mgallien
approved these changes
Mar 16, 2026
nilsding
enabled auto-merge
March 16, 2026 13:08
… folders `std::filesystem::remove` etc. seem to behave the same way as the pure win32-APIs: sometimes long paths work, sometimes they won't. In this case it seems to be able to deal with long UNC-style paths just fine ... Resolves #9293 Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
nilsding
force-pushed
the
bugfix/9293/win32-longpaths-recursive-deletion
branch
from
March 17, 2026 07:53
eff83ae to
fb6dd31
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-9634.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::filesystem::removeetc. seem to behave the same way as the pure win32-APIs: sometimes long paths work, sometimes they won't. In this case it seems to be able to deal with long UNC-style paths just fine ...Resolves #9425 (also mentioned in #9293 (comment))