[stable-34.0] fix(file-provider): preserve special characters in chunked upload paths - #10544
Merged
Conversation
Split the raw remote path without interpreting it as a URL so reserved characters in filenames remain intact until NextcloudKit encodes the WebDAV destination. Add regression coverage for reserved characters and invalid paths. fixes #10539 Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
backportbot
Bot
requested review from
camilasan,
claucambra,
i2h3,
mgallien and
nilsding
as code owners
August 6, 2026 09:07
claucambra
approved these changes
Aug 6, 2026
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10544.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Aug 20, 2026
https://build.opensuse.org/request/show/1372114 by user stacheldrahtje + anag_factory - Update to version 34.0.2: * [stable-34.0] fix(file-provider): Deletion of server-side item for items excluded from sync (gh#nextcloud/desktop#10540) * [stable-34.0] fix(tray): activate tray window also on right click (macOS) (gh#nextcloud/desktop#10542) * [stable-34.0] fix(file-provider): preserve special characters in chunked upload paths (gh#nextcloud/desktop#10544) * [stable-34.0] fix(discovery): use QString to avoid dangling QStringBuilder. (gh#nextcloud/desktop#10557) * [stable-34.0] fix(socketapi): defer move item dialog out of socket read loop. (gh#nextcloud/desktop#10578) * [stable-34.0] fix(windows): Prevent reupload of placeholder dirs deleted remotely (gh#nextcloud/desktop#10585) * [stable-34.0] fix(macOS): present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #10541