Skip to content

Add EnableObject - #148

Open
cielavenir wants to merge 6 commits into
masterfrom
AddEnableObject
Open

Add EnableObject#148
cielavenir wants to merge 6 commits into
masterfrom
AddEnableObject

Conversation

@cielavenir

@cielavenir cielavenir commented Feb 8, 2024

Copy link
Copy Markdown
Contributor
  • Adds EnableObject and EnableLink APIs. A customer needs them to reset itl state partially. Corresponding tasks are already implemented in our planningcommon.

    • But we should add the API to master to avoid the name collision in the future.
  • Grab/Release json had trailing commas. ujson.loads() seems ignoring them, but let's fix them as well. fixed by Fix JSON strings #159

@cielavenir

Copy link
Copy Markdown
Contributor Author

@kanbouchou any comments? or could you approve?

@cielavenir

Copy link
Copy Markdown
Contributor Author

b8449f4 was pointed out by the customer. we would need to have better review process. /cc @ntohge @ziyan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant