Skip to content

Support non-headless mode for autowebcompat-repro - #6689

Open
jgraham wants to merge 3 commits into
masterfrom
autowebcompat_no_headless
Open

Support non-headless mode for autowebcompat-repro#6689
jgraham wants to merge 3 commits into
masterfrom
autowebcompat_no_headless

Conversation

@jgraham

@jgraham jgraham commented Aug 21, 2026

Copy link
Copy Markdown
Member

This uses fluxbox running in Xvfb as the WM/display, similar to the configuration we have for web-platform-tests

@jgraham
jgraham requested a review from a team as a code owner August 21, 2026 17:39
@jgraham
jgraham requested a review from ksy36 August 21, 2026 17:40
@jgraham
jgraham force-pushed the autowebcompat_no_headless branch from 6b334ff to e472205 Compare August 21, 2026 17:41
@jgraham
jgraham force-pushed the autowebcompat_repro_script_mozregression branch from f36b21f to b9a8db0 Compare August 21, 2026 17:42
@jgraham
jgraham force-pushed the autowebcompat_no_headless branch 2 times, most recently from 8c5b6c0 to 2837a4a Compare August 21, 2026 17:49
Base automatically changed from autowebcompat_repro_script_mozregression to master August 21, 2026 17:57
@ksy36
ksy36 force-pushed the autowebcompat_no_headless branch from 2837a4a to f9dd5d1 Compare August 21, 2026 17:57
@jgraham
jgraham force-pushed the autowebcompat_no_headless branch from f9dd5d1 to cdaf5c6 Compare August 25, 2026 14:51
Comment thread agents/autowebcompat-repro/Dockerfile Outdated
&& chown agent:agent /workspace /app/repro
&& chown agent:agent /workspace /app/repro \
&& usermod -a -G sudo agent \
&& echo 'ALL ALL = (ALL) NOPASSWD: ALL' >> /etc/sudoers

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if there's a reason to give the agent passwordless root? fwiw I tried it without that, dropped the sudo package, the usermod/sudoers lines, and the two sudo prefixes in start_xvfb() and the display works fine (took a screenshot from inside the container to confirm).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently not! I thought this was needed, but now removed since it doesn't seem to be.

),
]
)
self.start(["sudo", "fluxbox", "-display", os.environ["DISPLAY"]])

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be a problem on production, only for development, but I've noticed if the container is reused (docker compose up on a stopped-but-not-removed container rather than a fresh one), the second run fails to get a display:

autowebcompat-repro-agent-1  | (EE) 
autowebcompat-repro-agent-1  | Fatal server error:
autowebcompat-repro-agent-1  | (EE) Server is already active for display 99
autowebcompat-repro-agent-1  |  If this server is no longer running, remove /tmp/.X99-lock
autowebcompat-repro-agent-1  |  and start again.
autowebcompat-repro-agent-1  | (EE) 
autowebcompat-repro-agent-1  | Warning: Failed to open file(fluxbox.cat)
autowebcompat-repro-agent-1  | for translation, using default messages.
autowebcompat-repro-agent-1  | Error: Couldn't connect to XServer:99.0

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to make the shutdown cleaner, I think this will help.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jgraham
jgraham force-pushed the autowebcompat_no_headless branch from cdaf5c6 to 5297eac Compare August 26, 2026 08:39
This uses fluxbox running in Xvfb as the WM/display, similar to
the configuration we have for web-platform-tests
@jgraham
jgraham force-pushed the autowebcompat_no_headless branch from 5297eac to dd9a6ec Compare August 26, 2026 08:41
@jgraham jgraham closed this Aug 27, 2026
@jgraham jgraham reopened this Aug 27, 2026
@jgraham
jgraham enabled auto-merge (squash) August 27, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants