PYTHON-5885 - Client Backpressure with retryAfterMS#2877
Open
NoahStapp wants to merge 16 commits into
Open
Conversation
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Note: SERVER-130142 will rename |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for using retryAfterMS from retryable overload errors to influence the client’s adaptive retry backoff, plus updates handshake backpressure metadata and related tests/docs.
Changes:
- Parse and propagate
retryAfterMSfrom server error documents into the overload backoff calculation. - Update hello/handshake backpressure field value (and metadata tests) to
"2". - Add a new prose-style timing test validating that
retryAfterMSreduces overload backoff.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
pymongo/errors.py |
Parses retryAfterMS from error details into PyMongoError. |
pymongo/synchronous/mongo_client.py |
Uses retryAfterMS override when computing overload retry backoff (sync). |
pymongo/asynchronous/mongo_client.py |
Uses retryAfterMS override when computing overload retry backoff (async). |
pymongo/synchronous/helpers.py |
Adjusts backoff helper to accept an override base backoff (sync). |
pymongo/asynchronous/helpers.py |
Adjusts backoff helper to accept an override base backoff (async). |
pymongo/synchronous/pool.py |
Updates handshake hello backpressure value (sync). |
pymongo/asynchronous/pool.py |
Updates handshake hello backpressure value (async). |
test/test_client_backpressure.py |
Adds a new test for retryAfterMS-driven backoff behavior (sync). |
test/asynchronous/test_client_backpressure.py |
Adds a new test for retryAfterMS-driven backoff behavior (async). |
test/test_client_metadata.py |
Updates handshake backpressure assertion (sync). |
test/asynchronous/test_client_metadata.py |
Updates handshake backpressure assertion (async). |
doc/changelog.rst |
Updates changelog entry for 4.18.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5885
Changes in this PR
Adds
retryAfterMSsupport for backoff calculation on retryable overload errors.Test Plan
Adds a new prose test
test_05_overload_errors_with_retryafterms_override_backoffto verify theretryAfterMSbehavior. Note that this new test requires a server withretryAfterMSsupport.Checklist
Checklist for Author
[ ] Is any followup work tracked in a JIRA ticket? If so, add link(s).Checklist for Reviewer