fix: tolerate unregistered listening stream for server-initiated messages - #1115
Closed
slachiewicz wants to merge 1 commit into
Closed
Conversation
slachiewicz
force-pushed
the
fix/streamable-server-initiated-push-grace
branch
from
August 28, 2026 17:15
74138de to
3ccb4ec
Compare
CryoThrust
reviewed
Aug 31, 2026
CryoThrust
left a comment
CryoThrust
left a comment
There was a problem hiding this comment.
The bounded retry/backoff and coverage for buffer-until-register, exhaustion, and handler-initiated pushes look aligned with the race described in #1114. I especially appreciate keeping the logical session alive while tolerating a not-yet-registered stream. I will watch for any maintainer feedback on the retry bound and lifecycle semantics.
…d messages Right after initialize, the server may push a server-initiated request (e.g. roots/list when the client declared the roots capability) before the client has opened its GET /mcp stream. The session previously delegated to a MissingMcpTransportSession that failed immediately with Stream unavailable for session <id>, surfacing as an intermittent -32603/500 on the clients POST (seen in CI HttpServletStreamableIntegrationTests.testRootsNotificationWithEmptyRootsList). Changes: introduce package-private MissingListeningStreamException (subclass of IllegalStateException, same message) thrown by MissingMcpTransportSession; McpStreamableServerSession.sendRequest/sendNotification retry missing-stream failures with exponential backoff capped at 12 attempts (~5s); accept(notification) falls back to the retrying session facade when no stream is registered yet so handler-initiated pushes are covered too. Related: modelcontextprotocol#952, modelcontextprotocol#1061
slachiewicz
force-pushed
the
fix/streamable-server-initiated-push-grace
branch
from
August 31, 2026 13:09
3ccb4ec to
9ddc5de
Compare
Contributor
|
As mentioned in #1114 , we don't plan on handling retry on missing handlers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right after initialize, the server may push a server-initiated request (e.g. roots/list when the client declared the roots capability) before the client has opened its GET /mcp stream; the session then failed with Stream unavailable for session (intermittent -32603/500, seen in HttpServletStreamableIntegrationTests CI). sendRequest/sendNotification now retry missing-stream failures with bounded backoff (~5s) and accept(notification) routes handler-initiated pushes through the retrying session facade. Related: #952, #1061. New unit tests cover buffer-until-register, correlation, grace exhaustion, and the handler-push path. Happy to adapt the approach per maintainer guidance.
Fixes #1114