Add GLFW feature to Dawn port#52678
Draft
oliverdixon wants to merge 3 commits into
Draft
Conversation
This adds a feature [glfw] to the Dawn port to set the DAWN_USE_GLFW cache variable. It requires patching an upstream CMakeLists.txt file, as Dawn expects GLFW3 to be cloned in-source as a submodule. The patch makes it use the system GLFW (provided as a vcpkg transitive dependency) instead.
Contributor
|
@oliverdixon please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
The Dawn GLFW utilities create a CMake target, but the target is not currently installed (thus available to consumers of the vcpkg port).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a feature [glfw] to the Dawn port to set the DAWN_USE_GLFW cache variable. It requires patching an upstream CMakeLists.txt file, as Dawn expects GLFW3 to be cloned in-source as a submodule. The patch makes it use the system GLFW (provided as a vcpkg transitive dependency) instead.
Fixes #49973
./vcpkg x-add-version --alland committing the result.